Would you rather forget everything that happened more than 24 hours ago but otherwise live your dream life, or have a normal memory but experience suffering often in your life? You’d retain all the memories you have up to this point, either way, but if you chose to have a short memory, you’d forget anything that happened from hereon.
Shit, that’s a hard one, since your memories define you so much. What kind of suffering are we talking about?
From poverty to losing loved ones to more minor problems. Maybe illness of some kind too (though nothing too debilitating). You’d have all your basic needs met, though–you wouldn’t be homeless and rummaging through garbage bins, for instance.