I think Yellow might be my favourite colour lightsaber, yellow lightsabers make me think of the KOTOR games.
Yellow sabers makes me think of Yun from Jedi Knight: Dark Forces II.
I would go green even though red is my favorite colour. I guess because of the association with Luke Skywalker, Jedi Knight who was my childhood hero.