I had more of an issue with the narrative’s use of Holdo in the plot than with the character herself. (Always loved Laura Dern.)
I found that I couldn’t fully buy into Poe being demoted, so Holdo’s role didn’t seem as essential as it should have.
If he had not destroyed the Dreadnaught, the laser canon on that sucker would have destroyed the Raddus for sure, even while it was such a distance away.
It also felt jarring that it seemed as if Holdo might have been a spy, but then she ends up as a hero. It just felt like subversion for the sake of subversion to me.
That said, I thought that angle might have been interesting and served the plot better if Paige Tico (who was portrayed as dying a Heroic Martyr’s death,) had actually been a 1st order spy, and actually betrayed the resistance. (by giving the 1st order the frequency of the resistance’ bombers shields or something.)
That way, Holdo appears to be a spy but is actually a hero, while someone who appears to be a hero (Paige) actually wasn’t one. It would have played well with helping the audience to see Luke’s whole change in perspective about the dangers of blindly venerating one’s heroes.
just my opinion